search

jeffsieu / pe

0 stars 0 forks source link

Data is encrypted, advanced users cannot manipulate the data #6

Open jeffsieu opened 2 years ago

jeffsieu commented 2 years ago

Issue

The data is encrypted in the file addressbook.enc. This is not in accordance to the constraint Constraint-Human-Editable-File set "To allow advanced users to manipulate the data by editing the data file."

image.png

Steps to reproduce

  1. Launch the application
  2. Create a password
  3. Close the application
  4. Navigate to the .data/ folder
  5. Open the addressbook.enc file.
  6. Its contents are encrypted.

Expected behaviour

Files not to be encrypted to allow advanced users to manipulate the data by editing the data file.

Actual behaviour

File cannot be edited meaningfully by the user

Screenshots

image.png

nus-pe-bot commented 2 years ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Violating the constraint "Constraint-Human-Editable-File" mentioned in module website

Expected
I wanted to test the error messages when I manually edit the json file to provide invalid values. When SPAM launches, it should detect that the data file contains such invalid values and notify the user.

Actual
The data file is located in ./data as a .enc file which I could not manually edit and change to test the storage loading feature. Although there is the import feature that the team implemented well, I am unsure if the import feature and the initial storage load feature have the same implementation, and there is no way for me to catch the error which I expected to see.

In addition, the files that I import are not the storage files that SPAM loads on start-up, hence testing on import files alone is not sufficient enough to prove that the initial load feature works on corrupted files.

Screenshots

image.png

image.png

[original: nus-cs2103-AY2122S1/pe-interim#2490] [original labels: severity.Low type.FeatureFlaw]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

See here.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

:question: Issue severity

Team chose [severity.Low] Originally [severity.Medium]

Reason for disagreement: [replace this with your explanation]