search

jeffsieu / pe

0 stars 0 forks source link

Corrupted file shows incorrect message #7

Open jeffsieu opened 2 years ago

jeffsieu commented 2 years ago

Issue

A corrupted data file causes the application to display the wrong error message

Steps to reproduce

  1. Launch the application
  2. Create the password "password"
  3. Close the application
  4. "Corrupt" the data by adding "abcdef" to the front of the .data\addressbook.enc file.
  5. Launch the application
  6. Enter the password "password"
  7. The error message shows "Wrong password"

Expected behaviour

The error message shows "Data file corrupted".

Actual behaviour

The error message shows "Wrong password", causing the user to re-enter his password in multiple futile attempts.

Screenshots

image.png

image.png

Bug severity justification

This would have been tagged Medium, as it is a rather serious bug, however, data corruption is not common. Also, if the data were corrupted, the data will be lost anyway, hence the wrongness of the error message is not severe. Hence this issue has been tagged Low.

nus-pe-bot commented 2 years ago

Team's Response

This is mentioned in the DG's manual testing section here. This is expected behaviour.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: [replace this with your explanation]

:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: This is not something wrong with the planned aspect of the feature. This is something wrong with the expected vs actual behaviour. Hence it should be a functionality bug image.png

:question: Issue severity

Team chose [severity.VeryLow] Originally [severity.Low]

Reason for disagreement: This does cause a minor inconvenience as a user cannot distinguish between a corrupted file or an unknown password. image.png