"Settings" is not translated in the hamburger menu of the sidebar - Githubissues

jeffvli / feishin

A modern self-hosted music player.

https://feishin.vercel.app

GNU General Public License v3.0

2.03k stars 79 forks source link

"Settings" is not translated in the hamburger menu of the sidebar #355

Open OriginCode opened 8 months ago

OriginCode commented 8 months ago

Expected Behavior

Translated string should be shown instead of "Settings"

Current Behavior

Steps to Reproduce

Select any language other than English in the settings.
Open the menu in the sidebar.

Possible Solution (Not obligatory)

N/A

Context

N/A

Your Environment

Application version (e.g. v0.1.0) : v0.5.1
Operating System and version (e.g. Windows 10) : AOSC OS (GNU/Linux 6.4.11, x86_64)
Server and version (e.g. Navidrome v0.48.0) : v0.49.3
Node version (if developing locally) : N/A

kgarner7 commented 5 months ago

The problem here is that all of the non-English translation files are missing two things:

A definition for common.setting_other (settings pluralized)
For page.appMenu.settings having the value $t(common.setting_other)

If you are (or anyone else for that matter) can update this for your native/familiar language(s) (visit https://hosted.weblate.org/projects/feishin/), that'd be great!