jeffvli / feishin

A modern self-hosted music player.
https://feishin.vercel.app
GNU General Public License v3.0
2.47k stars 106 forks source link

Accept incomplete information as Discord status #358

Closed Trapigtrogen closed 10 months ago

Trapigtrogen commented 11 months ago

Expected Behavior

Discord status should show what I'm playing even with missing information

Current Behavior

If current song doesn't have all needed information, Discord status freezes to previous song or doesn't start if no proper song was played previously.

Steps to Reproduce

  1. Optionally play song that shows in Discord status

  2. Play song without album information

  3. Discord is showing previous song info with 0 seconds left or no information if song without album was the first thing played

Context

Playing downloaded music from YouTube or other unofficial source that doesn't have all the metadata. Metadata also has not been found by lidarr of jellyfin. For example any of these unofficially remastered Moomin music don't have metadata anywhere https://open.spotify.com/album/66SQzT6zdfqm9Bt61kEcfW

I think it's because of the src/renderer/features/discord-rpc/use-discord-rpc.ts line 34 where the artists are mapped. What if there's no artists? I couldn't get the thing built so couldn't confirm myself

Trapigtrogen commented 11 months ago

I got it built and it showed the info raw So made PR while at it