jeffvli / feishin

A modern self-hosted music player.
https://feishin.vercel.app
GNU General Public License v3.0
2.04k stars 79 forks source link

Missing ":albumId" param after selecting "Random" sorting in Tracks tab #378

Closed manuel-rw closed 2 months ago

manuel-rw commented 8 months ago

Expected Behavior

The Tracks tab shows the songs of Jellyfin.

Current Behavior

The page does not load and shows a warning after I switched to "Random" sorting. Now I can't reset the sorting.

image

Restarting the application does not fix it.

Possible Solution (Not obligatory)

jeffvli commented 8 months ago

For a temporary fix, open up the dev tools with ctrl+shift+i and remove the store_song key from local storage to reset the filter.

image

jeffvli commented 8 months ago

Actually, I'm unable to reproduce this issue on my side -- also using Jellyfin 10.8.12.

iiPythonx commented 8 months ago

Jellyfin 10.9.0, not seeing this issue.

manuel-rw commented 6 months ago

I'll close this issue as I haven't been able to reproduce this myself.

m00dymann commented 6 months ago

I have run into the same problem on web version.

Edit: It happens when I swap from "Display type: Table" to Display type: Poster" whilst in the Tracks tab. Songs were sorted by recently added in descending order. Am using Brave browser.

kgarner7 commented 5 months ago

This bug appears to happen when you have a song without an album id; in this case, the LIBRARY_ALBUMS_DETAIL path breaks. I am able to reproduce this in Jellyfin 10.8.13 and unstable (for some reason Jellyfin just refuses to acknowledge my albums...). This issue happens for Jellyfin when in Card/Poster display for songs. Unfortunately, I'm not sure how to address this...

timaeos commented 3 months ago

For those encountering this issue, take a look at #531 .

It seems like this is likely a consequence of having files in the top-level of the Music directory structure. If you have files in the top-level, I'd recommend placing them into a directory to match the structure as noted in the Jellyfin documentation. For singles that don't have associated albums, throwing them into a Singles folder is sufficient.

After updating the directory structure, make sure that you clear Feishin's cache

kgarner7 commented 3 months ago

Adding on here, I will still look into adding a dummy album page when the album ID is nonexistent (Feishin shouldn't just panic even if Jellyfin behavior is strange).

nothing2obvi commented 3 months ago

I just opened Feishin after using it a few days ago just fine and now I get this same error, only on the Home page. I am running the x64 dmg on an Intel Mac.

timaeos commented 3 months ago

I just opened Feishin after using it a few days ago just fine and now I get this same error, only on the Home page. I am running the x64 dmg on an Intel Mac.

@kgarner7 is working on #553 which should hopefully resolve this but in the meantime, check if you have any songs in the top level of your directory structure and if you do, try moving them into a directory and clearing Feishin's cache as noted above

OriCat101 commented 3 months ago

Idk if this helps, but I get the same error even tho I have no "loose" songs kicking around in my library

YourSandwich commented 2 months ago

Same issue here, when scrolling through Tracks