search

jeffvli / feishin

A modern self-hosted music player.
https://feishin.vercel.app
GNU General Public License v3.0
2.44k stars 103 forks source link

Top Songs for an artist appear to be in random order #410

Closed Harteex closed 7 months ago

Harteex commented 9 months ago

Expected Behavior

Top Songs for an artist should be ordered in a sensible order, for example based on plays or at least recent plays.

Current Behavior

Top Songs are sorted in a way that doesn't make sense, as far as I can tell. It places songs with no plays at all higher up than those that have. bild

Steps to Reproduce

  1. Click an artist and view Top Songs

Possible Solution (Not obligatory)

Context

Your Environment

Optekah commented 9 months ago

It's always been like this for me too, so it's not just you. Jellyfin and Navidrome both on Unraid.

On a somewhat related note, The "recent albums" on this same page as the "top songs" also seem to not display in anything other than a random order as well. Albums from 2023 are buried in the list while ones from the middle or even the beginning of an artists career can pop up at the very forefront.

jeffvli commented 9 months ago

For Jellyfin the sort uses CommunityRating I believe, which in the case of no metadata will return a random sort. I'll probably just change this to use the PlayCount instead.

Navidrome should work properly, granted you have the lastfm integration enabled, since it pulls the top song list from there.

iiPythonx commented 9 months ago

On a somewhat related note, The "recent albums" on this same page as the "top songs" also seem to not display in anything other than a random order as well. Albums from 2023 are buried in the list while ones from the middle or even the beginning of an artists career can pop up at the very forefront.

+1 for this, I can't say I'm having the track sorting issue but my albums on Navidrome are definitely in a random order. According to the Navidrome UI: image

And then Feishin: image

Optekah commented 9 months ago

I personally have no use for the "top songs" and stuff like that haha. I would be super grateful if there was a way to just display all releases by an artist in grid format as soon as I click on the band name. Perhaps I could make a request post.

Navidrome should work properly, granted you have the lastfm integration enabled, since it pulls the top song list from there.

Ah this makes sense. Good to know, thanks!

jeffvli commented 9 months ago

I would be super grateful if there was a way to just display all releases by an artist in grid format as soon as I click on the band name. Perhaps I could make a request post.

Someone already opened an issue for this (though I don't know which one it is off the top of my head), but it's already something I was planning on implementing.

Regarding the recent releases album ordering on Navidrome -- I just confirmed it as well. For some reason the _sort parameter is missing when performing the query which is why it's using a random order. I'll fix that soon.

Optekah commented 9 months ago

but it's already something I was planning on implementing

Fantastic news. Very thankful for all your hard work!

cyberwolfie1 commented 8 months ago

but it's already something I was planning on implementing

Fantastic news. Very thankful for all your hard work!

I am also very happy about this planned enhancement :)

iiPythonx commented 7 months ago

Regarding the recent releases album ordering on Navidrome -- I just confirmed it as well. For some reason the _sort parameter is missing when performing the query which is why it's using a random order. I'll fix that soon.

Are there still plans on this being fixed? Artist albums still show up in a random order when viewing their artist page with Navidrome.

kgarner7 commented 7 months ago

Yes, see https://github.com/jeffvli/feishin/commit/24bf7ae31fcd7f248cd5c2c68fd3526d0954450e. Sort is by year since that's supported for v0.48.0-current, eventually it can be release date when server features are available