Make space bar the default shortcut for play/pause

jeffvli / feishin

A modern self-hosted music player.

https://feishin.vercel.app

GNU General Public License v3.0

1.99k stars 78 forks source link

Make space bar the default shortcut for play/pause #425

Closed codenyte closed 5 months ago

codenyte commented 6 months ago

What do you want to be added?

Space bar is a really common keyboard shortcut for play/pause. It's used in various applications/websites like e.g. Spotify, Apple Music, Navidrome, YouTube, VLC, mpv, etc. I discovered that you can manually add a shortcut for play/pause, but I think that basic things like this should be the default.

iiPythonx commented 5 months ago

but i do not see a way to bind play and pause to the same shortcut just as a toggle

What version are you running? I'm running 0.5.3 and I have options for all 3 inside my settings:

tmcelroy2202 commented 5 months ago

Yeah this was a brain issue. I have absolutely no clue how i missed that. Gonna delete my comments now.

kgarner7 commented 5 months ago

Resolved by https://github.com/jeffvli/feishin/commit/097211954c57db766606d00cd7137bdc8c6580d1 This won't update existing settings, but will work for new installs