jeffvli / feishin

A modern self-hosted music player.
https://feishin.vercel.app
GNU General Public License v3.0
2.12k stars 82 forks source link

Taskbar menu translation missing #504

Open TianMiao8152 opened 5 months ago

TianMiao8152 commented 5 months ago

Expected Behavior

Current Behavior

Steps to Reproduce

1.

2.

3.

4.

Possible Solution (Not obligatory)

Context

Your Environment

iiPythonx commented 5 months ago

What operating system are you on? What language did you set Feishin to use?

TianMiao8152 commented 5 months ago

What operating system are you on? What language did you set Feishin to use?

Windows 10 Pro 22H2,language is chinese I think it's a problem of lost translation key.

iiPythonx commented 5 months ago

So, what do you mean by the taskbar menu?

Closest thing I can think of would be the hover window: image

(In which everything is in English, I'm not sure Feishin controls the text that shows up in that window.)

TianMiao8152 commented 5 months ago

OK, I probably should have put up the pictures in advance. image

iiPythonx commented 5 months ago

Oh, I see what you mean.

I'm not sure about the Stop/Open Main Window/Quit keys All of those are controlled by Feishin (my bad). ie. see https://github.com/jeffvli/feishin/blob/development/src/main/main.ts#L157-L197

I guess they just need to have translation keys added to them.

TianMiao8152 commented 5 months ago

OK, I think most of the translation keys already exist and can be reused. This is not a big problem.

TianMiao8152 commented 4 months ago

Oh, I see what you mean.

~I'm not sure about the Stop/Open Main Window/Quit keys~ All of those are controlled by Feishin (my bad). ie. see https://github.com/jeffvli/feishin/blob/development/src/main/main.ts#L157-L197

I guess they just need to have translation keys added to them.

还没有更新吗?

iiPythonx commented 4 months ago

还没有更新吗?

Unfortunately not, I'm unable to add this feature myself because it would take quite a bit of work to be able to pull your language setting correctly in the main app file.