Closed iiPythonx closed 2 months ago
vercel[bot]
commented
3 months ago The latest updates on your projects. Learn more about Vercel for Git ↗︎
| Name | Status | Preview | Comments | Updated (UTC) |
|---|---|---|---|---|
| feishin | ✅ Ready (Inspect) | Visit Preview | 💬 Add feedback | Apr 1, 2024 3:35am |
iiPythonx
commented
3 months ago It would be good to have a way to open in browser (maybe when clicking on the notification?)
Went ahead and made it so clicking on the success notification does indeed open the share in browser.
It might be nice to have the ability to view existing shares, but this is a lower priority (I may take a look at implementing this).
I'll leave that up to you then (if you decide to work on it).
iiPythonx
commented
2 months ago Replacement is at https://github.com/jeffvli/feishin/pull/575 (sorry!).
PR that adds an option for sharing an album or songs via Navidrome (nothing else yet), resolves #80.
There are more then likely a lot of issues with how I did this, if you have any feedback on it please lmk (considering I've still barely touched React in my life).
Two nitpicks:
resourceTypebased on the first item you've selected. This should be fine since I'm assuming you can't magically select two items of different types within Feishin (ie. selecting an album and a song at the same time).Anyways, as stated in the beginning, any feedback would be very much appreciated.