[bugfix]: Resolve MPV next/prev race condition

jeffvli / feishin

A modern self-hosted music player.

https://feishin.vercel.app

GNU General Public License v3.0

2k stars 79 forks source link

[bugfix]: Resolve MPV next/prev race condition #566

Closed kgarner7 closed 3 months ago

kgarner7 commented 3 months ago

Resolves #536.

With the previous implementation, next/previous would first update the current queue and then call next/previous. However, since these were asynchronous calls it was very likely that the second calls would fail (and a test of adding delay showed that it actually caused a double skip). This PR resolves this by just removing the prev/next.

Small other fixes:

setQueue + pause -> setQueue(..., true)
make MPV and web player have the same behavior for (pause/stop) where appropriate

vercel[bot] commented 3 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
feishin	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Mar 31, 2024 4:53am