jeffvli / feishin

A modern self-hosted music player.
https://feishin.vercel.app
GNU General Public License v3.0
2.46k stars 103 forks source link

mpris "playing" status is not properly updated when changing tracks #570

Closed natperron closed 6 months ago

natperron commented 6 months ago

Expected Behavior

The playing/paused status should be updated properly when changing tracks manually or automatically (at the end of the previous track).

Current Behavior

When paused and skipping to next track, the status of the player is "Playing" (when it should stay "Paused"). Similar issue happens when the current track is playing and ends: instead of staying in status "Playing", the player changes to "Paused". image

Steps to Reproduce

  1. Pause on a track.
  2. Click on the button to skip to next track.
  3. Notice the playing status (using playerctl) is not the same as the status in Feishin.
    • Feishin is paused, but playerctl is "Playing"

Alternative:

  1. Let a track end. It should go to the next track.
  2. Notice the playing status (using playerctl) is not the same as the status in Feishin.
    • Feishin is playing, but playerctl is "Paused"

Context

I'm using playerctl to make my own music module for my task bar (using eww). Since it has the wrong playing status, I have a "paused" button when playing (and vice-versa) when this bug happens.

Your Environment

kgarner7 commented 6 months ago

Resolved by https://github.com/jeffvli/feishin/commit/65eca32de3e70b128b7bd5ba9e270563acf28844