jeffvli / feishin

A modern self-hosted music player.
https://feishin.vercel.app
GNU General Public License v3.0
2k stars 79 forks source link

Track progress bar stops working after cuing with keyboard #581

Closed comatus1649 closed 2 months ago

comatus1649 commented 2 months ago

Expected Behavior

If you have previously clicked on the track progress bar, it is possible to cue the track by pressing the left and right keyboard buttons. The elapsed time counter should update to reflect the selected point in the track, and then continue to count up as playback continues. The visual indicator of the progress bar should also reflect continued playback.

Current Behavior

After clicking on the progress bar, it is possible to cue (jump a few seconds backwards or forwards) using the keyboard. The time elapsed updates correctly, but then gets stuck where it is.

Steps to Reproduce

  1. Play a track
  2. Click on the progress bar.
  3. Say the playback time is 1:00. Press left keyboard button to cue to eg 0:50
  4. Let playback continue
  5. Observe that the music continues, but the counter stays at 0:50 and the progress bar is frozen

Possible Solution (Not obligatory)

No suggestion

Context

This makes it harder to cue repeatedly as once it has been done once, the progress bar and timestamp doesn't start working again until the next track.

Your Environment

kgarner7 commented 2 months ago

Resolved by https://github.com/jeffvli/feishin/commit/cabd69772ee6ce442ad2ac6a437b36167bcfce50