If I start two instances of Feishin with MPV playback enabled, I should be able to use both instances without issue.
Current Behavior
The first instance of Feishin creates an MPV socket at /tmp/node-mpv.sock using the current user's permission:
srw------- 1 chili chili 0 Mai 20 21:46 /tmp/node-mpv.sock=
Subsequent instances of Feishin from different users (for example pepper) are unable to start playback using MPV since they do not own the socket and are unable to re-create or access it.
Furthermore, Feishin does not clean up after itself when closing and the socket lingers until /tmp is cleared.
Steps to Reproduce
Launch Feishin as user chili (example)
Start playback
Close Feishin
Log in as user pepper (example)
Launch Feishin
Start playback
Playback does not start
Possible Solution
In src/main/features/core/player/index.ts:92 the extra constant is created which is the appended to the socket name. This could be re-used to add some unique identifier to the name, i.e. username, random string, etc.
Expected Behavior
If I start two instances of Feishin with MPV playback enabled, I should be able to use both instances without issue.
Current Behavior
The first instance of Feishin creates an MPV socket at
/tmp/node-mpv.sockusing the current user's permission:Subsequent instances of Feishin from different users (for example
pepper) are unable to start playback using MPV since they do not own the socket and are unable to re-create or access it.Furthermore, Feishin does not clean up after itself when closing and the socket lingers until
/tmpis cleared.Steps to Reproduce
chili(example)pepper(example)Possible Solution
In
src/main/features/core/player/index.ts:92theextraconstant is created which is the appended to the socket name. This could be re-used to add some unique identifier to the name, i.e. username, random string, etc.Context
No response
Application version
0.7.2
Operating System and version
Arch Linux,
feishin-binpackage from AURServer and Version
Navidrome 0.51.1
Node Version (if developing locally)
No response