jeffvli / feishin

A modern self-hosted music player.
https://feishin.vercel.app
GNU General Public License v3.0
1.99k stars 78 forks source link

Support non-square cover art #625

Closed Hydronicx closed 1 month ago

Hydronicx commented 1 month ago

What do you want to be added?

Currently, non-square cover art is cropped to the lowest dimension. This is not desirable. Non-square art should be supported and displayed in full.

Some albums have non-square cover art (think DVDs, box sets, etc.). Moreover, even regular cover art that should be square in theory might be slightly less square. Current behavior results in some cropping even in this case, which is not desirable.

Non-square cover art is supported for example in the Navidrome web UI.

Additional context

No response

Is this a server-specific feature? (e.g. Jellyfin only)

kgarner7 commented 1 month ago

Resolved by https://github.com/jeffvli/feishin/commit/38ed083693846d81ff6da89db05aadece05a47d2