jeffvli / feishin

A modern self-hosted music player.
https://feishin.vercel.app
GNU General Public License v3.0
1.99k stars 78 forks source link

[bugfix]: properly clean up MPV on quit, use pid for socket #627

Open kgarner7 opened 1 month ago

kgarner7 commented 1 month ago

This PR has two separate fixes:

  1. Use PID for socket to allow multi-user (and make development a bit cleaner)
  2. On Unix-based systems, delete the socket file on close (Windows appears to remove the pipe on close). Because teardown is async, the before-quit event is tweaked to prevent closing until the operation completes.

Resolves #622

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
feishin ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 26, 2024 5:28am