search

jeffvli / feishin

A modern self-hosted music player.
https://feishin.vercel.app
GNU General Public License v3.0
2.83k stars 116 forks source link

Scrolling in playlist view (not full playlist) of smart playlists in certain cases yields bad listings #733

Closed thebiblelover7 closed 2 months ago

thebiblelover7 commented 2 months ago

Expected Behavior

Feishin should show the playlist sorted all at once.

Current Behavior / Steps to Reproduce

As you can see in the following recording, when scrolling through the playlist page (not the full playlist page) of a smart playlist, the sorting gets a bit messed up.

https://github.com/user-attachments/assets/598e11e1-4fd3-40d4-9fd1-bb59d8ae9c47

I assume it may have to do with setting the sorting to "random"...

Screenshot 2024-09-08 at 7 33 40 PM

Possible Solution

For smart playlists that yield different results on every query (e.g., sorting=random), load the whole playlist when loading the playlist page.

Application version

v0.8.0

Operating System and version

MacOS Ventura 13.6.3

Server and Version

Navidrome v0.52.5

kgarner7 commented 2 months ago

See: https://github.com/navidrome/navidrome/pull/3244 (this also impacts Navidrome's own UI)

kgarner7 commented 2 months ago

It has been merged, new Navidrome release probably this week

thebiblelover7 commented 2 months ago

Perfect, thanks!