jeffvli / feishin

A modern self-hosted music player.
https://feishin.vercel.app
GNU General Public License v3.0
2.46k stars 103 forks source link

Play Random all songs not working since version 0.8.0 #750

Open IanAuckes opened 1 week ago

IanAuckes commented 1 week ago

Expected Behavior

When clicking the Play button in the pop-up from Random Play button, the player should shuffle and play all songs (when not specifying any filters).

Current Behavior

The pop-up stays as is. Nothing happens on clicking Play.

Steps to Reproduce

  1. Launch Feishin
  2. Click Play Random button.
  3. Without modifying anything in the pop-up, click Play.

Possible Solution

There is a "Play Filter" added to the Random Play pop-up in v0.8.0 That could be causing some issue.

Context

I have been using the Random Play without any filter to shuffle all songs in my library. It has been working till v0.7.3

Application version

v0.9.0

Operating System and version

Linux Mint 21.1 Cinnamon

Server and Version

Jellyfin v10.8.13

Node Version (if developing locally)

No response

kgarner7 commented 1 week ago

I am observing that this works just fine with both 10.8.13 and latest. Please try https://feishin.vercel.app (https://github.com/jeffvli/feishin/commit/b628b684ae92ab435c21ddf55fa3d2aa96fab720) and verify it works there, or use inspect element to show the exact error(s) occurring.

IanAuckes commented 1 week ago

First, my jellyfin version is 10.9.4. (If that makes any difference). Sorry about the mistake.

The behavior is same in the webpage and the AppImage: It works, but only when I fill in all the details (except Genre). If even one of the others are empty, it doesn't run.

Up to v0.7.3, I clicked play with all details empty and the player shuffled my entire library.

I checked the XHR output in Console of Inspect Element for v0.9.0 and v0.7.3 The Console output for v0.7.3 prints XHR finished loading: GET (followed by the link to my jellyfin) once and the music starts. While for the v0.9.0, it keeps repeating this line and the pop-up never disappears. Not sure how else to use Inspect Element to get error messages. If you could guide me, I can provide more details.

Kakoluz commented 6 days ago

I'm also suffering this error since update 0.9.0.

my jellyfin server is in version 10.9.6.

Been trying to look for an error message or a failed http request. But neither the console nor the network tab reports anything.

The only thing suspicius is a call to this endpoint in what seems as an infinite loop.

/users/userId/items?Fields=Genres%2C%20DateCreated%2C%20MediaSources%2C%20ParentId&IncludeItemTypes=Audio&Limit=100&Recursive=true&SortBy=Random%2CSortName&SortOrder=Ascending&StartIndex=0

I also suffer from the home tab not loading, stuck in an infinite loading spinner. I think both errors are related somehow as they started at the same time.