Subsonic 2, general rework

jeffvli / feishin

A modern self-hosted music player.

https://feishin.vercel.app

GNU General Public License v3.0

2.83k stars 116 forks source link

Subsonic 2, general rework #758

Closed kgarner7 closed 1 month ago

kgarner7 commented 1 month ago

Adapted from and supersedes #419. Resolves #306.

vercel[bot] commented 1 month ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
feishin	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Sep 26, 2024 4:12am

kgarner7 commented 1 month ago

Main weird thing that I haven't quite resolved is updating playlist when an item is removed. Other things should work fine (although fetching large playlists will be. long)

jeffvli commented 1 month ago

I might not have the time to go through every change, but as long as it's functional I'm fine with merging.

I'm not seeing the issue with playlist updates when a song is removed (it's working fine for me?), but the playlist list page itself is erroring out due to missing filters for subsonic.

I'll update as I go through it.

jeffvli commented 1 month ago

Couple more issues:

The table view doesn't respect the itemCount in regards to being able to infinitely scroll through all the data (happens on Album and Track list pages from what I can see)
Double clicking on a track in the track list (table view) seems to be adding an incorrect subset of songs

danjrwalsh commented 1 month ago

With this merged, might be a good idea to update the What music servers does Feishin support FAQ part of the readme