search

jeffwidman / bitbucket-issue-migration

A small script for migrating repo issues from Bitbucket to GitHub
GNU General Public License v3.0
316 stars 95 forks source link

move bb issue link to header, simplify templating #110

Closed ThomasWaldmann closed 6 years ago

ThomasWaldmann commented 6 years ago

the old template was creating a header and a footer.

this one is only creating a header (so less boilerplate) and just links the words "Original report" to the bitbucket url.

the attachments list (if any) is also in the header.

additionally to that, I made the templating easier by using a full template instead of splitting into header / content / footer - so stuff is easier to modify.

without bb_skip, it would have been even simpler, but i did not remove that. to support it, i added a second full template for report and comment.

the change is practically tested, i used this code to migrate to:

https://github.com/moinwiki/moin

ThomasWaldmann commented 6 years ago

https://github.com/moinwiki/moin/issues/196 this is how an issue with attachments looks like. without attachments, that 1 line is just missing.

jeffwidman commented 6 years ago

Sorry for the delay here, I missed the notifications earlier. Normally I'm not such a deadbeat. 😄

I'm going to merge this as is because its an improvement on the current state of affairs. But I wonder if there's room for further improvement... let's continue the discussion in https://github.com/jeffwidman/bitbucket-issue-migration/issues/109

PS: Thanks for all your hard work on https://github.com/borgbackup/borg.