search

jeffwidman / bitbucket-issue-migration

A small script for migrating repo issues from Bitbucket to GitHub
GNU General Public License v3.0
314 stars 97 forks source link

Errors in username formatting not caught during dry run #20

Closed jaraco closed 8 years ago

jaraco commented 9 years ago

In #19, I encountered an error, but only when I tried to run the migration for real. When I ran it using --dry-run, the error was not encountered. Dry run should probably catch errors in formatting.

TurkeyMan commented 9 years ago

It really should! It's impossible to DELETE bugs from GH >_< .. you can only 'close' them... So if this stuff's up, you've stuffed your bug database.

Also, -f doesn't work! I've tried -f 8 to start at issue 8, but it starts at 1 anyway.

linuxbandit commented 8 years ago

@TurkeyMan the problem with -f comes from Bitbucket's api that are broken, neither "start" nor "limit" work according to the docs. With 17 issues, if I pass -f 15 it copies the first 2 (=17-15) issues. Similarly, limit does not limit anything but it just takes the last X issues

jeffwidman commented 8 years ago

@jaraco did #25 fix this? If not, do you mind submitting your fix as a PR?

I created #32 as a new issue to track the broken -f option.

jaraco commented 8 years ago

@jeffwidman: I don't believe it did. The behavior of formatting a comment is still not captured in the dry run.

jeffwidman commented 8 years ago

Merged your fix. Thanks!