search

jeffwidman / cqlsh

Home of the cqlsh package on PyPI. Repackages the official Cassandra cqlsh for lighter-weight installs.
Apache License 2.0
19 stars 7 forks source link

strip_comment_blocks logic is reversed. #17

Closed wshang2022 closed 2 years ago

wshang2022 commented 2 years ago

I believe the logic is reversed. The strip_comment_blocks is meant to remove comments in "..." so it should not go into the if section if re.search('["].[/][].[][/].*["]', statementtext) return None. https://github.com/jeffwidman/cqlsh/blob/master/cqlsh/cqlsh.py#L905

example: INSERT INTO DB (abc) VALUES ('/*');

jeffwidman commented 2 years ago

It looks like this bug is with cqlsh itself... this repo is just the packaging to put it on PyPI.

So can you file a Jira against upstream Cassandra project?

More info here: https://github.com/jeffwidman/cqlsh#contributing