search

jeffwidman / cqlsh

Home of the cqlsh package on PyPI. Repackages the official Cassandra cqlsh for lighter-weight installs.
Apache License 2.0
19 stars 7 forks source link

Cassandra 4.1 #21

Closed bschoening closed 1 year ago

bschoening commented 1 year ago

Update the code to match the cassandra 4.1 release tag:

There are a number of cqlsh changes, grep the changelog for cqlsh to see details:

bschoening commented 1 year ago

Yes, it’s a direct copy from 4.1.

On trunk is my refactoring of csqlsh.py, that will be nice to see at some point in the future.

The python driver seems to have been abandoned by DataStax and hasn’t been updated in quite a while.

Sent from my iPhone

On Dec 17, 2022, at 1:26 PM, Jeff Widman @.***> wrote:

 @jeffwidman commented on this pull request.

In cqlsh/cqlsh.py:

@@ -116,20 +112,14 @@ def find_zip(libprefix): ver = os.path.splitext(os.path.basename(cql_zip))[0][len(CQL_LIB_PREFIX):] sys.path.insert(0, os.path.join(cql_zip, 'cassandra-driver-' + ver))

-third_parties = ('futures-', 'six-', 'geomet-') +# the driver needs dependencies +third_parties = ('six-', 'pure_sasl-') Actually, grep'ing the cqlshlib code, it looks like six was removed everywhere...

I assume this code still matches upstream, in which case we should keep it, but maybe upstream should be updated to drop six- from third_parties? I dunno, I haven't actually looked at this much...

— Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.

bschoening commented 1 year ago

No, that’s a gotcha, because the driver still uses it, it needs to be dynamically loaded, even though cqlshlib doesn’t use it.

Sent from my iPhone

On Dec 17, 2022, at 2:02 PM, Brad Schoening @.***> wrote: