search

jeffwils / grails-spring-security-saml

Grails Spring Security SAML2.0 Plugin for Grails 3
8 stars 24 forks source link

Migrate DefaultSamlSecurityConfig.groovy to plugin.yml #19

Closed valentingoebel closed 6 years ago

valentingoebel commented 6 years ago

It is recommended to use plugin.yml in grails 3.3.x plugins. The majority of crashes were caused by missing default values and do not appear anymore.

irstevenson commented 6 years ago

Change looks good. Haven't had a chance to test today though.

I'd be keen to spin it up in an app with no custom config and see if it avoids all those wonderful crashes. I think that'd be enough to give it a definite 👍. I'll try and do it Monday (AEDT) at the latest.

irstevenson commented 6 years ago

Alright, nice work!

I trimmed my config down to just my specific bits, and the app started and undertook successful authentication.

Next, I chopped out my whole saml: block, and the app still started nicely (as expected), and then on hitting /login/auth exceptions were thrown for missing IDP metadata etc (as also expected).

So, looks like it fixed it. Definitely enough so to merge.

Might be more to do later to do config validation, but this provides a far better experience for first time user.