jeffwils / grails-spring-security-saml

Grails Spring Security SAML2.0 Plugin for Grails 3
8 stars 25 forks source link

Active flag has no affect #33

Closed irstevenson closed 6 years ago

irstevenson commented 6 years ago

...however there has been a fix in the past, so we just need to add it back onto develop branch, test and be done.

See lines 79-84 of SpringSecuritySamlGrailsPlugin.groovy:

https://github.com/jeffwils/grails-spring-security-saml/blob/f54a8afe99adbac7ac886d7d58ede68110193323/src/main/groovy/org/grails/plugin/springsecurity/saml/SpringSecuritySamlGrailsPlugin.groovy#L79-L84

These should probably all be updated as per:

https://github.com/jeffwils/grails-spring-security-saml/commit/fd0150cd2ced1b7482e7907be46a2f21eb024e20#diff-040c2cc982d97779d0f006aef5310bfb

valentingoebel commented 6 years ago

Now that this is out of the way I'll close the issue.