The ClassPathResource to File conversion is a bit messy in my opinion. The only change is the indentation but the diff looks more complicated than it is. It should be put into it's own method and then it could perhaps even be reused for the IDP and SP metadata.
I've added a simple check if the provider path starts with http/https and then I create a HttpMetadataProvider based on the url.
I've also created a new configuration property aml.metadata.timeout` with the default value 5000 which was taken from here: https://docs.spring.io/spring-security-saml/docs/1.0.x/reference/html/configuration-metadata.html#configuration-metadata-idp-http
The ClassPathResource to File conversion is a bit messy in my opinion. The only change is the indentation but the diff looks more complicated than it is. It should be put into it's own method and then it could perhaps even be reused for the IDP and SP metadata.
Issue: https://github.com/jeffwils/grails-spring-security-saml/issues/17