Implement UTF8 support for metadata url

jeffwils / grails-spring-security-saml

Grails Spring Security SAML2.0 Plugin for Grails 3

8 stars 24 forks source link

Implement UTF8 support for metadata url #38

Closed valentingoebel closed 6 years ago

valentingoebel commented 6 years ago

You can confirm that the change works with

curl -D - localhost:8080/saml/metadata
...
Content-Type: application/samlmetadata+xml;charset=UTF-8

Issue: https://github.com/jeffwils/grails-spring-security-saml/issues/16

irstevenson commented 6 years ago

Confirmed working via my test app, all looks good other than maybe a code comment so that later we can remove when no longer needed (i.e. new Spring Security dependency available.)

Other than that good to merge me thinks. :+1:

irstevenson commented 6 years ago

Sorry, made the above comment 19 days ago, but didn't submit the review correctly. Sorry for delay on this one - which should've been nice and quick. User error. :(

valentingoebel commented 6 years ago

I forgot about this pull request because it's only a minor annoyance to me. It was very easy to "patch" without editing the source code of the library itself by simply including 3 lines in the resources.groovy. Now it's ready to be merged!