jeffwils / grails-spring-security-saml

Grails Spring Security SAML2.0 Plugin for Grails 3
8 stars 25 forks source link

New Release #57

Closed jnunderwood closed 4 years ago

jnunderwood commented 5 years ago

Please create a new release based on the develop branch. It has been almost a year since any additions were made to that branch, so it appears to be stable. This branch has several updates that fix issues affecting basic usability of the plugin.

The new release should be propagated to plugins.grails.org so users can easily include the plugin in their build.gradle files. Thank you.

valentingoebel commented 5 years ago

Without cooperation from jeffwils this isn't possible. I have decided to simply create a new bintray repository. If jeffwils ever comes back to upload the 3.3.1 version then it will be available in the central repository.

Here is how you can use the latest release:

repositories {
    maven { url "https://dl.bintray.com/valentingoebel/plugins" }
}

dependencies {
    compile 'org.grails.plugins:spring-security-saml:3.3.1'
}

I will add this to the README.MD later.

As a last warning: I have tried to change as little as possible back in 2018 when I updated the plugin. However I may have broken backwards compatibility by accident in some edge cases. In general everything should be alright if you have defined every property in the application.yml, provided your own metadata and keystore. If you have a sample/test app that uses the example files that were provided with the plugin then it will no longer work because we have removed them but I also added some helpful error messages that should make it obvious if a file is missing.

valentingoebel commented 5 years ago

I would appreciate it if someone else tests this and tells me if it works.

jeffwils commented 5 years ago

What do you need from me….I can do whatever needed or give you permission if necessary

From: valentingoebel notifications@github.com Reply-To: jeffwils/grails-spring-security-saml reply@reply.github.com Date: Thursday, June 6, 2019 at 7:07 AM To: jeffwils/grails-spring-security-saml grails-spring-security-saml@noreply.github.com Cc: Subscribed subscribed@noreply.github.com Subject: Re: [jeffwils/grails-spring-security-saml] New Release (#57)

Without cooperation from jeffwils this isn't possible. I have decided to simply create a new bintray repository. If jeffwils ever comes back to upload the 3.3.1 version then it will be available in the central repository.

Here is how you can use the latest release:

repositories {

maven { url "https://dl.bintray.com/valentingoebel/plugins" }

}

dependencies {

    compile 'org.grails.plugins:spring-security-saml:3.3.1'

}

I will add this to the README.MD later.

As a last warning: I have tried to change as little as possible back in 2018 when I updated the plugin. However I may have broken backwards compatibility by accident in some edge cases. In general everything should be alright if you have defined every property in the application.yml, provided your own metadata and keystore. If you have a sample/test app that uses the example files that were provided with the plugin then it will no longer work because we have removed them but I also added some helpful error messages that should make it obvious if a file is missing.

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/jeffwils/grails-spring-security-saml/issues/57?email_source=notifications&email_token=ADNJVBYSKZME35LTLBPNGXDPZDVVPA5CNFSM4HBZLJMKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODXCQGHY#issuecomment-499450655, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADNJVBZMZLNEAICCZHYLRLDPZDVVPANCNFSM4HBZLJMA.

valentingoebel commented 5 years ago

Last march you published the 3.3.0 version of the plugin to the official grails plugin repository. Now 3.3.1 has been released with some new features. All you have to do is upload the current 3.3.1 branch to bintray and submit it for inclusion in the official repository.

jnunderwood commented 5 years ago

I would appreciate it if someone else tests this and tells me if it works.

This seems to be working for me. Thanks! Would still like an update in the "official" bintray location, if possible.

valentingoebel commented 5 years ago

@jeffwils can you upload the latest version to http://repo.grails.org/?

valentingoebel commented 4 years ago

I have uploaded it already.