search

jeffwright13 / apg_flask

Flask wrapper around the [audio program generator](https://github.com/jeffwright13/audio_program_generator) module
0 stars 3 forks source link

Enhancement: rename apg class "AudioProgramGenerator" #4

Closed jeffwright13 closed 3 years ago

jeffwright13 commented 3 years ago

Per Bob's suggestion:

apg would be better as instance variable (uppercase = constant), if you call the class AudioProgramGenerator and import it like from app.apg import AudioProgramGenerator there won't be a variable clash.

This is in reference to views.py, the code that says:

if to_mix:
    A = apg.Apg(
        phrase_file,
        to_mix,
        sound_file,
        attenuation,
    )
bbelderbos commented 3 years ago

nice tracking

jeffwright13 commented 3 years ago

Simultaneously being tracked in apg issue 8

Key takeaway" "Rename Apg claas to AudioProgramgenerator (from Bob's suggestion in apg_flask). This will require rework in apg's main() as well as in apg_flask's views.py"

jeffwright13 commented 3 years ago

Implemented for apg module in ecba9e0. Will still need to accomodate new classname in apg_flask (views.py), but waiting for PR to complete and then will have to reupload to Pypi. Then 'poetry build' 'poerty update' and 'poetry publish' for this repo.

jeffwright13 commented 3 years ago

Done