JnyJny commented 2 years ago

Addresses issue #16 and allows package to be installed via pip as intended.

jeffwright13 commented 2 years ago

Good catch! Now what is the protocol here - do submitters usually merge their own PRs?

JnyJny commented 2 years ago

Typically, the owner of the repo is the only one that actually initiates the commit. I don't have a commit button.

sourcery-ai[bot] commented 2 years ago

Sourcery Code Quality Report

Merging this PR leaves code quality unchanged.

Quality metrics	Before	After	Change
Complexity	6.83 ⭐	6.83 ⭐	0.00
Method Length	31.62 ⭐	31.62 ⭐	0.00
Working memory	5.75 ⭐	5.75 ⭐	0.00
Quality	77.44% ⭐	77.44% ⭐	0.00%

Other metrics	Before	After	Change
Lines	542	542	0

Changed files	Quality Before	Quality After	Quality Change
setup.py	85.59% ⭐	85.59% ⭐	0.00%
pytest_fold/init.py	96.17% ⭐	96.17% ⭐	0.00%
pytest_fold/plugin.py	53.37% 🙂	53.37% 🙂	0.00%
pytest_fold/tui.py	84.60% ⭐	84.60% ⭐	0.00%
pytest_fold/utils.py	73.90% 🙂	73.90% 🙂	0.00%
tests/init.py	96.17% ⭐	96.17% ⭐	0.00%
tests/test_pytest_fold.py	96.18% ⭐	96.18% ⭐	0.00%

Here are some functions in these files that still need a tune-up:

File	Function	Complexity	Length	Working Memory	Quality	Recommendation
pytest_fold/plugin.py	pytest_configure	38 ⛔	234 ⛔	11 😞	27.10% 😞	Refactor to reduce nesting. Try splitting into smaller methods. Extract out complex expressions
pytest_fold/utils.py	sectionize	11 🙂	104 🙂	11 😞	55.95% 🙂	Extract out complex expressions
pytest_fold/plugin.py	pytest_configure.tee_write	8 ⭐	182 😞	8 🙂	56.28% 🙂	Try splitting into smaller methods
pytest_fold/tui.py	ResultsFrame.__init__	5 ⭐	121 😞	11 😞	59.40% 🙂	Try splitting into smaller methods. Extract out complex expressions

Legend and Explanation

The emojis denote the absolute quality of the code:

The 👍 and 👎 indicate whether the quality has improved or gotten worse with this pull request.

Please see our documentation here for details on how these metrics are calculated.

We are actively working on this report - lots more documentation and extra metrics to come!

Help us improve this quality report!