search

jefriMDivanli / prj-rev-bwfs-dasmoto

0 stars 0 forks source link

SUMMARY #6

Open rimmesbe opened 6 years ago

rimmesbe commented 6 years ago

Grade: Satisfactory

Summary: Nice job on this project, the site looks good. You used some good techniques and kept your code well organized. Take a look at the issues I created as they will point out some code optimizations and some best practices you can start using. Overall well done, you are ready for the next units. If you are interested in using more semantic tags like nav (and I do recommend it) check this article out: https://www.pluralsight.com/guides/html-css/semantic-html?aid=701j0000001heIqAAI&promo=&oid=&utm_source=google&utm_medium=ppc&utm_campaign=CA_Dynamic&utm_content=&utm_term=&gclid=CjwKCAjwlrnNBRBMEiwApKU4PBiUM7wtxiyqNw-6Zoikh6ChlNul6tTL839Zj2h_JNTZcK6PE5WWlRoCiOYQAvD_BwE

jefriMDivanli commented 6 years ago

Hi Ryan,

Thank you for your feedback and the link to the pluralsight.com. Now that you pointed what could be done better, I can see it clearer. Looking back, I realised that i easily got excited when the code that I wrote worked. This excitement blinded me from thinking of how to make the code better, or, if there is something wrong with my code, such as the nav element. I have made the necessary changes on my Atom file for my future reference, and promise myself to be more conscientious. However, I have some questions:

firstly, regarding your number 2 feedback.

When I give an attribute to a div element, should I delete the attribute on the h2 element that belong to that particular div? I think, to give two different attribute for div and h2 could make the css code shorter, but it also make the HTML code look more crowded. My question is, which is the industry standard for this? And what is your opinion on this?

Secondly, regarding the location of index.html and style.css files.

I notice that I have to put both file within the same folder (in this case both index and style files are located in Dasmoto/index.html.). Is it a good practice to do that? Or should I keep them in 2 separate folders within Dasmoto directory?

Thank you once again for your feedback and time. I am looking forward to your answer, and have a great day and week ahead! :)

M.

rimmesbe commented 6 years ago

index.html should be in the main dasmoto folder, and the css should be in a "resource" folder or even a css folder inside the resource folder.

As far as the attribute, you could move it off of the h2 and into the div. You could just chain from that attribute on the div for the styling the background color on the h2: .brushes h2 { } but lets say you wanted a class to style all h2s inside these sections, then you would make a class for the h2s as well.

On Sun, Dec 17, 2017 at 7:43 AM, md89code notifications@github.com wrote:

Hi Ryan,

Thank you for your feedback. Now that you pointed what could be done better, I can see it clearer. Looking back, I realised that i easily got excited when the code that I wrote worked. This excitement blinded me from thinking of how to make the code better, or, if there is something wrong with my code, such as the nav element. I have made the necessary changes on my Atom file for my future reference, and promise myself to be more conscientious. However, I have some questions:

firstly, regarding your number 2 feedback.

When I give an attribute to a div element, should I delete the attribute on the h2 element that belong to that particular div? I think, to give two different attribute for div and h2 could make the css code shorter, but it also make the HTML code look more crowded. My question is, which is the industry standard for this? And what is your opinion on this?

Secondly, regarding the location of index.html and style.css files.

I notice that I have to put both file within the same folder (in this case both index and style files are located in Dasmoto/index.html.). Is it a good practice to do that? Or should I keep them in 2 separate folders within Dasmoto directory?

Thank you once again for your feedback and time. I am looking forward to your answer, and have a great day and week ahead! :)

M.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/md89code/prj-rev-bwfs-dasmoto/issues/6#issuecomment-352253192, or mute the thread https://github.com/notifications/unsubscribe-auth/AJfw_CWuN4qz-AVuG7tjGebxGLAUp5xAks5tBQyBgaJpZM4REapG .

jefriMDivanli commented 6 years ago

Noted! Thanks a lot Ryan! Merry Christmas/Happy Holiday and Happy 2018! :)