search

jegasus / world-manager

A Python-based tool that helps manage FoundryVTT Worlds.
GNU General Public License v3.0
13 stars 5 forks source link

Appears to check duplicates only on filename, not on any kind of hashing #2

Closed Aeristoka closed 3 years ago

Aeristoka commented 3 years ago

This appears to cause duplicative file names (even in different directories) to get cleared out after the first one is processed.

jegasus commented 3 years ago

Hi there! Thanks for checking the tool out! Can you please be a bit more descriptive with your problem? For example, what images existed before and what existed existed after you ran the tool? Also, the code actually does check file hashes for duplicates, not filenames. In fact, the code doesn't do ANY kind of filename checking. Could you also please send some screenshots of what you tried and what happened next? Thanks again for the feedback =)

Aeristoka commented 3 years ago

In example here, a single folder that was worked on: Original: image

Worked on: image

Worked on _trash: image

Aeristoka commented 3 years ago

My guess about file name checking was based on this: image

image

All files represented in that one scene.

Next scene: image

image

jegasus commented 3 years ago

Thanks for the extra info. This seems to be a duplicate of #6 . I'm marking this as a bug and currently investigating why this is happening.

jegasus commented 3 years ago

I've fixed the issue in release 0.0.2! The problem was in the function that fixes image files' extensions (for example, from PNG to JPEG). I'm closing the issue. If the problem persists, please feel free to re-open it!

Aeristoka commented 3 years ago

I am super excited to test this 0.0.2 release! 😄

Aeristoka commented 3 years ago

Another example R20Exporter/R20Converter world as in #6 👍 image

Insanely good results!