jegelstaff / formulize

Unified data management. One system to handle all data entry, collection, and reporting, across all your unique workflows. Simplify processes. Make people happy.
https://www.formulize.org
GNU General Public License v2.0
27 stars 14 forks source link

Introduce new e2e testing scaffolding #492

Closed arvinsingla closed 5 months ago

arvinsingla commented 5 months ago

This PR ads the foundation of using Playwright as the new e2e test runner.

The PR ads the following:

Q&A

Why not use the existing CI folder for tests? CI is a bit of a misnomer. CI specific configuration files are now stored in their namespaced directories (e.g. .github). So /tests is where we would expect the tests themselves to live. Since these tests can be run in many environments (e.g. CI, Locally, etc) it's confusing if they stay in the CI folder

Why keep the CI folder? Once all the existing tests have been ported over to playwright we can remove the CI folder. Until then they are still available and can be used.

Why are the saucelabs steps commented out in the github actions file? I am still evaluating the usefullness of using SauceLabs vs. having playwright generating testing output locally. Currently playwright is generating the testing output and writing it as assets to the action.

jegelstaff commented 5 months ago

In general, looks great. Just see the one comment about whether we can have a way to turn this off if we really don't need it on a commit/merge

arvinsingla commented 5 months ago

Bases on updates this is now RTBC