jegesh / python-sqs-listener

A simple wrapper for boto3 for listening, and sending, to an AWS SQS queue
Other
154 stars 71 forks source link

Added long polling support. #16

Closed MPlugInSpace closed 6 years ago

MPlugInSpace commented 6 years ago

Hello,

In using your library at work(NewsCycle Solution) I need to support long polling so I added an optional parameter to support it. In my testing the default behavior is not changed with the default value of '0'. Unfortunately the effect of a WaitTimeSeconds=0 is not documented so I can offer no further support of this not changing the default behavior. This is my first pull request on GitHub so if any of this is 'off' let me know.

Thanks, Gabriel Norton

jegesh commented 6 years ago

Your intuition served you well. As per the documentation, setting WaitTimeSeconds=0 invokes short polling. Thanks for the contribution!

MPlugInSpace commented 6 years ago

Good catch, thanks for the link, I had been looking in the boto3 docs and did not think to look in service docs.