search

jegesh / python-sqs-listener

A simple wrapper for boto3 for listening, and sending, to an AWS SQS queue
Other
154 stars 71 forks source link

Various minor refactors #24

Closed AdrieanKhisbe closed 5 years ago

AdrieanKhisbe commented 6 years ago

This leads many imporvement to the library, cf commit list.

I have other in mind:

Do you have tests? (or test recipe to set it up?)

Thanks in advance for your response @jegesh :)

jegesh commented 6 years ago

I have a few questions for you, as well:

  1. Are you just trying to bolster your github profile by making these suggestions?
  2. Why would I want to convert the README to markdown, since as you yourself stated, it's not supported by pypi, and then I'd have to maintain two readme's, separately? Is there any advantage to markdown (besides the fact that more people are familiar with it)?

I don't mean to sound hostile, but I honestly don't understand what drove you to make this pull request, unless you just have a ton of time on your hands and are a really nice guy. I like to think of myself as a practical person. While I see the value in the changes you made, they don't have any effect on the functionality of the package. I, personally, would never bother to make a pull request for something that wasn't either solving a problem or making an actual improvement on the code.

AdrieanKhisbe commented 5 years ago
  1. I don't see how this PR would bolster my github profile, honestly.

  2. I didn't understand your answer until I saw I made a typo. I meant:

    convert the README from rst to markdown, NOW this is supported by Pypi

    sorry for the misunderstanding

You are right they have have any effect on the functionality, but I think they have an effect on the discoverability of the library. Without the badge I had to dig more into the source code to have an idea I should use the library or no.

Best regards