search

jegesh / python-sqs-listener

A simple wrapper for boto3 for listening, and sending, to an AWS SQS queue
Other
154 stars 72 forks source link

Added stop method for graceful shutdowns #26

Closed tyronegroves closed 5 years ago

tyronegroves commented 5 years ago

This gives the listener graceful shutdowns. I specifically need this feature for automated integration tests so I don't get errors when stopping the listener and I don't have to create multiple processes on our build servers with the daemon.

jegesh commented 5 years ago

Hi Tyrone! Thanks for contributing to the repo! Have you tested your code with python 2.7 as well as 3.x? (I'm asking out of ignorance, since I'm not really familiar with the threading module)

tyronegroves commented 5 years ago

No I haven't. But I will test it today and post back here.

tyronegroves commented 5 years ago

Looks like it works just the same under 2.7

odedva commented 1 year ago

hey @jegesh - I wonder why did you undo this capability? could not find a reason in the commit log and looking for the capability to gracefully shutdown it through a threading event \ other injected state (which i can offer as PR if needed)