search

jegesh / python-sqs-listener

A simple wrapper for boto3 for listening, and sending, to an AWS SQS queue
Other
154 stars 72 forks source link

FIFO: set the FifoQueue property to true when the queue name ends wit… #6

Closed priordan83 closed 7 years ago

priordan83 commented 7 years ago

…h .fifo.

priordan83 commented 7 years ago

AWS forces you to create FIFO queues with the suffix .fifo in the queue name. Just my opinion but if someone has named a queue with the .fifo suffix I think we can safely assume that the queue is FIFO.

From Amazon docs:

"The name of a FIFO queue must end with the .fifo suffix. The suffix counts towards the 80-character queue name limit. To determine whether a queue is FIFO, you can check whether the queue name ends with the suffix."

http://docs.aws.amazon.com/AWSSimpleQueueService/latest/SQSDeveloperGuide/FIFO-queues.html

On Tue, Jun 27, 2017 at 7:28 AM, Yaakov Gesher notifications@github.com wrote:

@jegesh commented on this pull request.

Is this a known convention? Or just a feature you'd like to have?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jegesh/python-sqs-listener/pull/6#pullrequestreview-46453042, or mute the thread https://github.com/notifications/unsubscribe-auth/AQMyH-FxZK75logfdMFC_juRelXWvh6wks5sIKEcgaJpZM4OFbRY .

priordan83 commented 7 years ago

Any update on this, or would you prefer I fork my changes?

jegesh commented 7 years ago

Sorry it took me so long to back to this

priordan83 commented 7 years ago

Any chance of getting this change in pip?

On Sun, Jul 16, 2017 at 1:53 PM, Yaakov Gesher notifications@github.com wrote:

Sorry it took me so long to back to this

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/jegesh/python-sqs-listener/pull/6#issuecomment-315607411, or mute the thread https://github.com/notifications/unsubscribe-auth/AQMyH5SvCNzYPnlB_FJ_J5vR9k9L9yWcks5sOgfdgaJpZM4OFbRY .