search

jegonzal / PowerGraph

PowerGraph: A framework for large-scale machine learning and graph computation.
343 stars 518 forks source link

Wrong engine type in graph_algorithsm #169

Open august782 opened 9 years ago

august782 commented 9 years ago

In the graph_algorithms directory (graphlab/toolkits/graph_algorithms), the engine type passed to the constructor of the omni_engine is incorrectly spelled as "asyncronous" instead of "asynchronous", e.g. in djikstra.cpp line 407:

graphlab::omni_engine engine(dc, graph, "asyncronous", clopts);

Running any of these applications would fail as the hard-coded value is not acceptable, crashing the system with a fatal error. This hard-coded value should be changed to "async" or "asynchronous" to run correctly.

dmcennis commented 9 years ago

This problem was fixed in September before its release. Which version of the source are you accessing?

august782 commented 9 years ago

As far as I can see, this is in the repository right now (from the front page, https://github.com/graphlab-code/graphlab. The time of the commit is September 15 (and seems to be the latest change to the directory graph_algorithsm), commit 7e0a8082. In fact, in this commit, the original option for setting the engine type was changed to be hard-coded to this value.

dbickson commented 9 years ago

Hi August, Can you please send a pull request? I will merge in ASAP

thanks!!

august782 commented 9 years ago

I submitted a pull request where I changed the spelling. However, according to discussion with Daniel, it sounds like this should have already been added a while ago. Could there be other changes that are not reflected in the current repository? I ask this because on a related note, as I was trying to run the betweeeness code, the application would report a betweeneess of 0 for every node in my graph, and I'm not sure if it may be due to the code I have reflecting what should actually be there.

dbickson commented 9 years ago

I just merged your code - thanks again! My suggestion is to diff Daniel's github and ours, it may be that he have added some fixes which are not incorporated at our repo.

http://www.graphlab.com Danny Bickson Co-Founder US phone: 206-691-8266 Israeli phone: 073-7312889 https://twitter.com/graphlabteam http://www.linkedin.com/company/graphlab https://www.facebook.com/graphlabinc http://www.youtube.com/user/GraphLabInc

On Sat, Dec 6, 2014 at 8:15 PM, august782 notifications@github.com wrote:

I submitted a pull request where I changed the spelling. However, according to discussion with Daniel, it sounds like this should have already been added a while ago. Could there be other changes that are not reflected in the current repository? I ask this because on a related note, as I was trying to run the betweeeness code, the application would report a betweeneess of 0 for every node in my graph, and I'm not sure if it may be due to the code I have reflecting what should actually be there.

— Reply to this email directly or view it on GitHub https://github.com/graphlab-code/graphlab/issues/169#issuecomment-65907947 .

dmcennis commented 9 years ago

Multiple updates to my Github account have disappeared and contents to several posts have changed from happy users to complaints. I seem to have been hit by a hacker redirect on my production box and there was source code damage on the box itself. I'm doing what I can.

dmcennis commented 9 years ago

dbickson, in future, please do not confirm to me that my source code has been correctly received if the code you received was not working.