jegonzal / PowerGraph

PowerGraph: A framework for large-scale machine learning and graph computation.
343 stars 518 forks source link

broken download links (Yosemite Mac OS X): zookeeper? #176

Open abitofalchemy opened 9 years ago

abitofalchemy commented 9 years ago

the files CMakeList.txt points to download files that aren't not the right size. after: ./configure and 'make' in folder debug/toolkits/graph_analytics/ I initially get: [ 45%] No install step for 'boost' [ 45%] Completed 'boost' [ 45%] Built target boost make: *\ [all] Error 2

if I type make again to get more specific details: [ 29%] Performing build step for 'zookeeper' libtool: compile: gcc -DHAVE_CONFIG_H -I. -I./include -I./tests -I./generated -Wall -Werror -g -O2 -D_GNU_SOURCE -MT zookeeper.lo -MD -MP -MF .deps/zookeeper.Tpo -c src/zookeeper.c -o zookeeper.o In file included from src/zookeeper.c:27: In file included from ./include/zookeeper.h:34: ./include/recordio.h:76:9: error: expected ')' int64_t htonll(int64_t v); ^ /usr/include/sys/_endian.h:141:25: note: expanded from macro 'htonll'

define htonll(x) __DARWIN_OSSwapInt64(x)

                    ^

/usr/include/libkern/_OSByteOrder.h:78:30: note: expanded from macro '__DARWIN_OSSwapInt64' (builtin_constant_p(x) ? DARWIN_OSSwapConstInt64(x) : _OSSwapInt64(x)) ^ ./include/recordio.h:76:9: note: to match this '(' /usr/include/sys/_endian.h:141:25: note: expanded from macro 'htonll'

define htonll(x) __DARWIN_OSSwapInt64(x)

                    ^

/usr/include/libkern/_OSByteOrder.h:78:5: note: expanded from macro '__DARWIN_OSSwapInt64' (builtin_constant_p(x) ? DARWIN_OSSwapConstInt64(x) : _OSSwapInt64(x)) ^ In file included from src/zookeeper.c:27: In file included from ./include/zookeeper.h:34: ./include/recordio.h:76:9: error: conflicting types for '__builtin_constant_p' int64_t htonll(int64_t v); ^ /usr/include/sys/_endian.h:141:25: note: expanded from macro 'htonll'

define htonll(x) __DARWIN_OSSwapInt64(x)

                    ^

/usr/include/libkern/_OSByteOrder.h:78:6: note: expanded from macro '__DARWIN_OSSwapInt64' (builtin_constant_p(x) ? DARWIN_OSSwapConstInt64(x) : _OSSwapInt64(x)) ^ ./include/recordio.h:76:9: note: '__builtin_constant_p' is a builtin with type 'int ()' /usr/include/sys/_endian.h:141:25: note: expanded from macro 'htonll'

define htonll(x) __DARWIN_OSSwapInt64(x)

                    ^

/usr/include/libkern/_OSByteOrder.h:78:6: note: expanded from macro '__DARWIN_OSSwapInt64' (builtin_constant_p(x) ? DARWIN_OSSwapConstInt64(x) : _OSSwapInt64(x)) ^ 2 errors generated. make[5]: * [zookeeper.lo] Error 1 make[4]: * [all] Error 2 make[3]: * [all] Error 2 make[2]: * [../deps/zookeeper/src/zookeeper-stamp/zookeeper-build] Error 2 make[1]: * [CMakeFiles/zookeeper.dir/all] Error 2 make: * [all] Error 2

intoraw commented 9 years ago

It seems boost compile failed. I came across the same problem, and find that cmake downloaded a 4KB boost_1_53_0.tar.gz file. Update boost download link in CMakeLists.txt to URL "http://tcpdiag.dl.sourceforge.net/project/boost/boost/1.53.0/boost_1_53_0.tar.gz" may fix this issue.

abitofalchemy commented 9 years ago

I tried the above and fixed the problem in zookeeper by applying the patch listed here

yusong-shen commented 8 years ago

Hi abitofalchemy . I came across the same problem. So how do you applying the patch to fix zookeeper? Could you explain a little bit more? Thanks very much! @zorksylar

yusong-shen commented 8 years ago

Never mind, I manage to figure it out. Since zookeeper 3.4.6 has some problems in Mac Yosemite, I just change the CmakeLists.txt on powerGraph root folder's zookeeper url to the newest version. older one is :

ExternalProject_Add(zookeeper PREFIX ${GraphLab_SOURCE_DIR}/deps/zookeeper URL http://apache.cs.utah.edu/zookeeper/zookeeper-3.4.6/zookeeper-3.4.6.tar.gz URL_MD5 971c379ba65714fd25dc5fe8f14e9ad1 PATCH_COMMAND ${CMAKE_COMMAND} -E copy_directory ${GraphLab_SOURCE_DIR}/patches/zookeeper/ BUILD_IN_SOURCE 1 CONFIGURE_COMMAND ./configure --prefix= --disable-shared INSTALL_DIR ${GraphLab_SOURCE_DIR}/deps/local)

New one is :

ExternalProject_Add(zookeeper PREFIX ${GraphLab_SOURCE_DIR}/deps/zookeeper URL http://mirror.metrocast.net/apache/zookeeper/zookeeper-3.5.1-alpha/zookeeper-3.5.1-alpha.tar.gz URL_MD5 d85f9751724d3f20f792803b61c4db24 PATCH_COMMAND ${CMAKE_COMMAND} -E copy_directory ${GraphLab_SOURCE_DIR}/patches/zookeeper/ BUILD_IN_SOURCE 1 CONFIGURE_COMMAND ./configure --prefix= --disable-shared INSTALL_DIR ${GraphLab_SOURCE_DIR}/deps/local)

larryxiao commented 8 years ago

@yusong-shen Thanks, the link works! However I see

[  0%] Performing patch step for 'zookeeper'
cd graphlab/deps/zookeeper/src/zookeeper && cmake -E copy_directory graphlab/patches/zookeeper/

Do you have idea about how to fix this? Thank you!

yusong-shen commented 8 years ago

@larryxiao I didn't encounter this problem. Do you mean it stuck at this step? Is there any error massage?

sekruse commented 8 years ago

I couldn't build PowerGraph, as well, because the cs.utah.edu mirror for Zookeeper is not working anymore. I changed it the CmakeLists.txt to https://archive.apache.org/dist/zookeeper/zookeeper-3.4.6/zookeeper-3.4.6.tar.gz and the build worked. The MD5 is the same. This URL looks like a stable mirror.

Edit: on Ubuntu, not MacOS X

larryxiao commented 8 years ago

@yusong-shen thanks for replying sorry, I forgot to include the error, the message is cmake usage. It seems that cmake -E copy_directory takes `source destination - copy directory 'source' content to directory 'destination'`` as parameter. I guess it's missing the destination.