search

jeheydorn / nortantis

Nortantis is a fantasy map generator. It uses a simple tectonic plate simulation to create islands and continents with trees, rivers, and mountains. The result has the appearance of an old-fashioned hand-drawn map.
GNU Affero General Public License v3.0
74 stars 20 forks source link

Color Map Error #29

Open SirJackDaReaper opened 1 day ago

SirJackDaReaper commented 1 day ago

Upon making a map and doing intensive editing to it with colors the map had a problem loading. And in trying to fix it by copying the map files into one new folder to repair so data wasn't lost. A new error appears when possibly reaching the max number of colors. The file shows it's at 255 colors on the map, and it's to represent countries in a time of war in the map. Below is the error:

Error while creating map: Color Parameter outside of expected range: Red Green Blue

This seems to be a basic java error, but I am unaware of how to fix this myself. This may be a color limit bug with Norton itself or something else from repairing lost work by coping code using Notepad++.

SirJackDaReaper commented 1 day ago

Map.ZIP

jeheydorn commented 1 day ago

There is a bug in Nortantis where it can only have 255 colors. The fix isn't hard - I simply need to use an image type that supports more than 256 values per pixel when drawing color indexes when drawing region colors. The reason I haven't done this is because it will take (a little) more memory, and I didn't think anyone would ever actually create a map with that many colors. But you proved me wrong :)

I went ahead and fixed this in my master branch and updated the beta version installer with the fix, so you can try the fix now. The new version is 2.85. You'll have to click through the Windows Defender warnings because I haven't submitted the installer for Microsoft's review yet. If you're concerned about that, I can submit it now, but it will take about a week and a half for them to review it.

On Wed, Sep 18, 2024 at 2:01 PM SirJackDaReaper @.***> wrote:

Map.ZIP https://github.com/user-attachments/files/17049654/Map.ZIP

— Reply to this email directly, view it on GitHub https://github.com/jeheydorn/nortantis/issues/29#issuecomment-2359301921, or unsubscribe https://github.com/notifications/unsubscribe-auth/ABY34KJ4BBJCRDK3ZKX7EPTZXHLYTAVCNFSM6AAAAABOONJVO2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNJZGMYDCOJSGE . You are receiving this because you are subscribed to this thread.Message ID: @.***>

SirJackDaReaper commented 1 day ago

Thank you I'll let you know how it goes! I have no problem with clicking through warnings when it comes to a bug fix.

Edit: This indeed fixed the problem, and if anything else comes up in the branch i'll be sure to mention it in the next day or so. Thank you again!