search

jehiah / json2csv

command line tool to convert json to csv
MIT License
802 stars 94 forks source link

Add support for nested fields #11

Closed jeroenjanssens closed 11 years ago

jeroenjanssens commented 11 years ago

Added a function get_value that can be called recursively in order to support the extraction of nested fields. The readme has been updated accordingly and there is an extra unit test called TestGetNested. If you pull these changes, you may want to change the "go get" line in README.md back to your repo.

jehiah commented 11 years ago

@jeroenjanssens these changes look great. sorry this past me. Can you update the readme to reflect it being the canonical version not a fork?

jeroenjanssens commented 11 years ago

No worries, glad you like it.

Sure, I'll change the README. Are you OK with keeping the example so that it illustrates that nested fields are supported?

jehiah commented 11 years ago

Yeah, I think the example txt is great

jeroenjanssens commented 11 years ago

Cool. I just updated the README on my forked repo. Do I need to change the existing pull request or put in a new one?

On Tue, Aug 13, 2013 at 5:18 PM, Jehiah Czebotar notifications@github.comwrote:

Yeah, I think the example txt is great

— Reply to this email directly or view it on GitHubhttps://github.com/jehiah/json2csv/pull/11#issuecomment-22598388 .

The above terms reflect a potential business arrangement, are provided solely as a basis for further discussion, and are not intended to be and do not constitute a legally binding obligation. No legally binding obligations will be created, implied, or inferred until an agreement in final form is executed in writing by all parties involved.

This email and any attachments hereto may be confidential or privileged. If you received this communication by mistake, please don't forward it to anyone else, please erase all copies and attachments, and please let me know that it has gone to the wrong person. Thanks.

jehiah commented 11 years ago

This is where it's awesome that pull-requests are live-updating diff's on your branch. No need for a new one. Thanks for the contribution!