Properly handle numbers, escape codes, quotes, and nulls

jehiah / json2csv

command line tool to convert json to csv

MIT License

802 stars 94 forks source link

Properly handle numbers, escape codes, quotes, and nulls #5

Closed thinkjson closed 11 years ago

thinkjson commented 12 years ago

This pull request fixes string escaping for numbers, escape codes like \n and \t, quotes (the CSV 'standard' specifies "" to escape a "), and nulls. We've also fixes a memory leak.

thinkjson commented 12 years ago

We're using this extensively in production now, and the changes above are essential for escaping data with quotes. We're using my repository at the moment, but it would be really cool if this pull request could be merged.

jehiah commented 11 years ago

Thanks for your patch, however i'm re-implementing in golang to clean up this code base and improve it a bit. As a result i'm closing this issue in favor of changes in #7

thinkjson commented 11 years ago

I had a feeling that was coming. I'm watching the repository now, so do you want me to submit a new set of unit tests once that code has been merged?