jehoshua02 / testem-example

Showing how easy it is to setup and use testem for TDD style workflow.
0 stars 0 forks source link

Webpack build process not failing testem #13

Open jehoshua02 opened 9 years ago

jehoshua02 commented 9 years ago

Not sure if this is on testem side or webpack side but running build in the absence of appropriate loaders, causing the webpack build process to file, isn't being acknowledged by testem, giving a false impression of positive results.

To reproduce:

git clone https://github.com/jehoshua02/testem-example.git
cd testem-example
git checkout e2dc6f53820355b20ffaf10eece4774809ddc66f
npm install
`npm bin`/webpack --config ./tests/webpack.config.js
npm test

I get the following output on running webpack:

~/projects/jehoshua02/testem-hello-world 🚀  babel [!$]
$ `npm bin`/webpack --config ./tests/webpack.config.js
Hash: 17d3a483c6d4e98a3d68
Version: webpack 1.7.3
Time: 44ms
                Asset     Size  Chunks             Chunk Names
unit/subdir/subdir.js  1.55 kB       0  [emitted]  unit/subdir/subdir.js
        unit/hello.js  1.87 kB       1  [emitted]  unit/hello.js
   [0] ./tests/unit/babel.js 0 bytes [built] [failed]
   [0] ./tests/unit/hello.js 281 bytes {1} [built]
   [0] ./tests/unit/subdir/subdir.js 133 bytes {0} [built]
   [1] ./src/hello.js 94 bytes {1} [built]

ERROR in ./tests/unit/babel.js
Module parse failed: /Users/employee/projects/jehoshua02/testem-hello-world/tests/unit/babel.js Line 3: Unexpected token {
You may need an appropriate loader to handle this file type.
| describe('babel-loader', function () {
|   it('should preprocess destructuring statements', function () {
|     var {one, two, three, ...other} = [1,2,3,4,5];
|     expect(one).toBe(1);
|     expect(two).toBe(2);

When when I run testem, everything looks fine. But I notice there are only 3 tests when I am expecting 4.

jehoshua02 commented 9 years ago

Reported on testem.

jehoshua02 commented 9 years ago

Reported on webpack.

mrsum commented 8 years ago

@jehoshua02 Hi, maybe my implementation will be helpfull https://github.com/rambler-digital-solutions/rambler-webpack-boilerplate/tree/master/.bin