I used Resharper to identify some code redundancies and clean up. I was very careful not to make any changes that would change behavior or change method/properties definition. The list below is basically in the same order as the changed files.
Remove empty object initializers
Empty statements (extra semicolons)
Added Assert.IsNotNull( obj ) in unit tests where could have been null reference exceptions
Changed calls from .Count() extension method to .Length or .Count property accessors
Remove redundant 'using statements' and redundant statements, ie ColumnContext.cs unused variable var columns = schema.ColumnDefinitions;
Added null argument check to fail fast on FlatFileDataReader.GetChars since Array.Copy would throw ArgumentNullException if buffer was null
Fixed order of modifiers "public override sealed string Format(" to "public sealed override string Format("
changed .Where(...).SingleOrDefault() to .SingleOrDefault(...)
jehugaleahsa
commented
6 years ago
I used Resharper to identify some code redundancies and clean up. I was very careful not to make any changes that would change behavior or change method/properties definition. The list below is basically in the same order as the changed files.