search

jehugaleahsa / SQLGeneration

Provides core classes for generating SQL at runtime.
The Unlicense
22 stars 10 forks source link

SQLGeneration/Builders/NotFilter.cs #9

Closed dazinator closed 10 years ago

dazinator commented 10 years ago

Please can you change the filter field on the following class SQLGeneration/Builders/NotFilter.cs to have a public property surrounding it? I need to get access to the negated filter..

I did do this in my fork however I seem to be having issues with merging via git at present - when i create pull requests it seems to detect changes to lines that are actually my changes, for example were changed when i pulled your latest changes, so think I will avoid pull requests as much as possible at present until I can figure out how to correctly use them without complicating things. I am fairly new to git at present!

jehugaleahsa commented 10 years ago

I can do that. I am surprised I didn't already do that. Thanks! On Mar 19, 2014 8:57 AM, "Darrell" notifications@github.com wrote:

Please can you change the filter field on the following class SQLGeneration/Builders/NotFilter.cs to have a public property surrounding it? I need to get access to the negated filter..

I did do this in my fork however I seem to be having issues with merging via git at present - when i create pull requests it seems to detect changes to lines that are actually my changes, for example were changed when i pulled your latest changes, so think I will avoid pull requests as much as possible at present until I can figure out how to correctly use them without complicating things. I am fairly new to git at present!

Reply to this email directly or view it on GitHubhttps://github.com/jehugaleahsa/SQLGeneration/issues/9 .

jehugaleahsa commented 10 years ago

The NotFilter class now exposes the inner filter. Good catch!