search

jehy / telegram-test-api

Simple implimentation of telegram API which can be used for testing telegram bots
MIT License
98 stars 24 forks source link

replace TestBot constructor with a procedure #60

Closed RB-Lab closed 3 years ago

RB-Lab commented 3 years ago

image ಠಿ_ಠ

image ಠ_ಠ

image (ノಠ益ಠ)ノ彡┻━┻

image ᕕ( ᐛ )ᕗ

(despite all my frustration ESLint, essentially, right: TestBot looks like a class but it is, in fact, a procedure that attaches side-effects in constructor. Which is misleading and, indeed, took me some mental efforts, when I first saw it)

coveralls commented 3 years ago

Coverage Status

Coverage remained the same at 86.957% when pulling 409b9b32b2835760cb7b106a39e2be3f5665d626 on RB-Lab:rb/rm-test-bot-constructor into e68c987aa02831397fac8500196365fed9f4b594 on jehy:master.

jehy commented 3 years ago

Yup, I suppose I was overthinking when made it a constructor :)