Remove VS2017_WIN64 generator as it won't compile.

jeikabu / nng-rust

MIT License

18 stars 8 forks source link

Remove VS2017_WIN64 generator as it won't compile. #21

Closed mrijkeboer closed 5 years ago

mrijkeboer commented 5 years ago

This fixes issue #20.

neachdainn commented 5 years ago

@jeikabu: I don't have a Windows machine to test this on. If it works and is worth updating the crate on Crates.io, I can do so.

jeikabu commented 5 years ago

Wasn't ignoring this, mean to look into it and just been busy. This worked before- it is how I was building it, after all. I suspect some version of cmake in the last year stopped allowing all of: -Thost=x64 -Ax64 -G "xxx Win64". Not sure it's worth finding out:

When it changed and use the appropriate flags behind a cmake version check
OR, if the flags in the PR work for all versions just switch to that

Also, wanted to make sure 32-bit builds still worked.

neachdainn commented 5 years ago

No worries on my end - take your time - I was mostly just letting you know that I also was not ignoring it.