jeikabu / runng

MIT License

25 stars 3 forks source link

Add lib64 to the library search path for finding nng #22

Closed najamelan closed 5 years ago

najamelan commented 5 years ago

I ran into this on Arch linux. Cmake generates a lib64 directory, so cargo build fails. This just adds lib64 to the search path, so either lib or lib64 should build fine.

codecov[bot] commented 5 years ago

Codecov Report

Merging #22 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   79.25%   79.25%           
=======================================
  Files          44       44           
  Lines        1658     1658           
=======================================
  Hits         1314     1314           
  Misses        344      344

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1acf214...233ae33. Read the comment docs.

codecov[bot] commented 5 years ago

Codecov Report

Merging #22 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   79.25%   79.25%           
=======================================
  Files          44       44           
  Lines        1658     1658           
=======================================
  Hits         1314     1314           
  Misses        344      344

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1acf214...233ae33. Read the comment docs.

jeikabu commented 5 years ago

Thanks for looking into this and submitting a fix.

jeikabu commented 5 years ago

I went ahead and published runng-sys 1.1.1-rc.3 with this fix since I assume there's other distros that are affected.

najamelan commented 5 years ago

Thanks for merging this fast. Do you want more feedback? I have been using runng for a few days now, so I could open some issues...

jeikabu commented 5 years ago

Sure. Mostly use it as an excuse to learn rust while we contemplate migrating from ZeroMQ to NNG. Can't hurt to open issues, but I make no promises about addressing them. =)