search

jeisenbath / ansible-collection-solarwinds-orion

An Ansible collection for managing nodes in Solarwinds Orion
11 stars 3 forks source link

Remove SNMPv3 credential set requirement #25

Closed Andyjb8 closed 3 months ago

Andyjb8 commented 3 months ago

Maybe there is a reason you had the SNMPv3 credential set as required, but until I can create them on the fly with ansible, it is causing an issue for me. I researched and tried but wasn't able to create a module to create a credential set. Originally I posted my issue here, https://github.com/jeisenbath/ansible-collection-solarwinds-orion/issues/3 but this way you can see my changes better. This change is working for me, but please validate it looks right.

jeisenbath commented 3 months ago

Yeah I don't have an issue with this. I might have made it required before I also found out you still are required to pass the other two params still, or just because I thought making individual ones wouldn't have a use case.

Technically this and the other PR I merged should also get included in the changelog. This is done with antsibull-changelog, so can you make a yaml in the doc_fragments for this PR as a minor_change? The next time I create a release then that will ensure it gets added to changelog.

Andyjb8 commented 3 months ago

I have not used antsibull-changelog before, but I will give it a try. Will this change be part of 2.0.0 or 2.0.1?

jeisenbath commented 3 months ago

If just for this change, that would be 2.0.1 (minor changes and bugfixes increase the third number, major changes i.e. new plugin second number, breaking changes first number). I would like to roll all of the remaining issues into a 2.1.0 release, however, so just the doc fragment is fine for now.