search

jeisenbath / ansible-collection-solarwinds-orion

An Ansible collection for managing nodes in Solarwinds Orion
10 stars 1 forks source link

Node update from icmp to snmpv3 #28

Open Andyjb8 opened 3 days ago

Andyjb8 commented 3 days ago

This related to Issue #14 Maybe I should have combined all changes I made today in one release version?

This worked for me to update from ICMP to SNMP. however if node was already SNMPv3 i got this error and could not figure it out.

"msg": "Failed to update node: 400 Client Error: Update failed.\r\nInvalid input for Node with NodeID:1290. Unable to update Node. Details : Error : In property SNMPV3Username. Reason : Mismatch in Type. Provided value is not of expected type System.String. Provided value type System.DBNull.\r\nError : In property SNMPV3PrivMethod. Reason : Mismatch in Type. Provided value is not of expected type System.String. Provided value type System.DBNull.\r\nError : In property SNMPV3AuthMethod. Reason : Mismatch in Type. Provided value is not of expected type System.String. Provided value type System.DBNull.\r\n\r\n----------------------------------\r\n. for url: https:/server:17774/SolarWinds/InformationService/v3/Json/swis://server/Orion/Orion.Nodes/NodeID=1290"

jeisenbath commented 3 days ago

Yeah, no need to make each commit an individual release. The way I've been doing it, new modules would be minor version update, so all of these can be rolled up into 2.1.0. I haven't ever managed a project like this too, maybe it would be good for me to make a devel-2.x branch and we can work it out through there.

jeisenbath commented 3 days ago

If you want to make the changes based on my comments, and do a PR to the devel-2.1.x branch instead of master, I'll use that to build the next release. Thanks for the contribution!