search

jejacks0n / mercury

Mercury Editor: The Rails WYSIWYG editor that allows embedding full page editing capabilities directly inline.
http://jejacks0n.github.com/mercury
Other
2.63k stars 531 forks source link

Preloading of Panels #281

Open bamtstic opened 11 years ago

bamtstic commented 11 years ago

Hi,

I was just trying out the preloading of panels and selects.

Selects work fine.

Preloaded panels do not show their close window button or the 'mercury-panel-pane', the visibility remains at hidden.

I will try to investigate further.

Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

bamtstic commented 11 years ago

Okay found it... I'm sorry to say but i'm still getting a grip on github/git/making pull requests/coffee script/rails, but i have resolved the issue.

One assumption i am making is that because the 'mercury-panel' containing various 'mercury-panel-pane' is not visible, the button and panel-pane doesn't need to be hidden.

app\assets\javascripts\mercury\panel.js.coffee
build: ->
    @element = jQuery('<div>', {class: 'mercury-panel loading', style: 'display:none;'})
    @titleElement = jQuery("<h1><span>#{Mercury.I18n(@options.title)}</span></h1>").appendTo(@element)
    @paneElement = jQuery('<div>', {class: 'mercury-panel-pane'}).appendTo(@element)

    if @options.closeButton
      jQuery('<a/>', {class: 'mercury-panel-close'}).appendTo(@titleElement).css({opacity: 1})

    @element.appendTo(jQuery(@options.appendTo).get(0) ? 'body')

loadContent: (data) ->
    @loaded = true
    @element.removeClass('loading')
    @paneElement.css({visibility: 'visible'})
    @paneElement.html(data)
    @paneElement.localize(Mercury.locale()) if Mercury.config.localization.enabled
jejacks0n commented 11 years ago

I appreciate you reporting and looking into this. When I have more time this afternoon I'll look into what you've found.

On Sep 27, 2012, at 12:36 AM, bamtstic notifications@github.com wrote:

Okay found it... I'm sorry to say but i'm still getting a grip on github/git/making pull requests/coffee script/rails, but i have resolved the issue.

One assumption i am making is that because the 'mercury-panel' containing various 'mercury-panel-pane' is not visible, the button and panel-pane doesn't need to be hidden.

app\assets\javascripts\mercury\panel.js.coffee build: -> @element = jQuery('

', {class: 'mercury-panel loading', style: 'display:none;'}) @titleElement = jQuery("h1><span>#{Mercury.I18n(@options.title)}</span").appendTo(@element) @paneElement = jQuery('
', {class: 'mercury-panel-pane'}).appendTo(@element)

if @options.closeButton
  jQuery('<a/>', {class: 'mercury-panel-close'}).appendTo(@titleElement).css({opacity: 1})

@element.appendTo(jQuery(@options.appendTo).get(0) ? 'body')

loadContent: (data) -> @loaded = true @element.removeClass('loading') @paneElement.css({visibility: 'visible'}) @paneElement.html(data) @paneElement.localize(Mercury.locale()) if Mercury.config.localization.enabled — Reply to this email directly or view it on GitHub.